Closed nevrome closed 9 months ago
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
d2dc568
) 68.49% compared to head (7453873
) 68.46%.
Files | Patch % | Lines |
---|---|---|
src/Poseidon/CLI/Jannocoalesce.hs | 27.27% | 4 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As suggested:
-- no changes
and-- copied
tologDebug
--stripIdSuffix
to--stripIdRegex
Uses POSIX Extended regular expressions.
to the documentation of-stripIdRegex
The rest are cosmetic changes to make code and output more consistent with other parts of trident.
Here's how the output can look now:
I think we should slowly stop to talk about "individuals" when we refer to .janno rows. This will be a long and slow process, but we should to become more clear in the terminology here.