posener / goreadme

Generate readme file from Go doc. Now available as a Github action!
MIT License
213 stars 31 forks source link

Converting master -> main #111

Closed eahrend closed 3 years ago

eahrend commented 3 years ago

Feel free to ignore this, but since github changed the default branch from master to main, newer repos trying to copy the example will fail. Had this happen to me.

posener commented 3 years ago

Sure thing. But please note that the readme file is autogenerated. The changes should be done in the go doc in goreadme.go.

codecov[bot] commented 3 years ago

Codecov Report

Merging #111 (0195c21) into master (1ac1c0f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files           3        3           
  Lines          81       81           
=======================================
  Hits           56       56           
  Misses         15       15           
  Partials       10       10           
Impacted Files Coverage Δ
goreadme.go 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ac1c0f...0195c21. Read the comment docs.

eahrend commented 3 years ago

@posener sorry about that, give me a bit.

posener commented 3 years ago

Hey, thanks for the change. But there is something strange with the CL. You should only have one file being changed: goreadme.go. Can you fix it?

eahrend commented 3 years ago

Hey, thanks for the change. But there is something strange with the CL. You should only have one file being changed: goreadme.go. Can you fix it?

I tried previously, but there were some merge conflicts between my fork and the most recent update. This was my attempt at fixing these merge conflicts. I'll admit that my git is a little lacking, especially when dealing with conflicts. It would probably be easier to close this PR and reopen it since the change is like 2 words.

posener commented 3 years ago

OK, I'll go ahead and make the change myself.

posener commented 3 years ago

Thanks @eahrend