posener / goreadme

Generate readme file from Go doc. Now available as a Github action!
MIT License
213 stars 31 forks source link

Obsolete dependency on posener/goaction v1.0.3 #92

Closed paskal closed 4 years ago

paskal commented 4 years ago

Hi there, that's what I see when I try to replicate installation command from Readme in an existing project:

$ go version
go version go1.14.2 darwin/amd64
$ GO111MODULE=on go get github.com/posener/goreadme/cmd/goreadme
go: downloading github.com/posener/goreadme v1.3.2
go: found github.com/posener/goreadme/cmd/goreadme in github.com/posener/goreadme v1.3.2
go get: github.com/posener/goreadme@v1.3.2 requires
    github.com/posener/goaction@v1.0.3: reading github.com/posener/goaction/go.mod at revision v1.0.3: unknown revision v1.0.3
posener commented 4 years ago

Hey Thanks. Yes, the goaction 1.0.3 was a "pre release", The dependency can be updated to v0.1.0. Do you want to submit a PR?

paskal commented 4 years ago

I've figured out how to use it by building locally and then using binary directly, my problem is solved. I would skip creating a PR if you don't mind, as your tags scheme seems complex and I don't understand what led to this situation and how to improve it, and I don't want to just bluntly do what you proposed without understanding.

posener commented 4 years ago

Glad to hear that your problem was solved. I see that the go.mod is good, just pushed a new release v1.3.3 that this issue should be fixed in.