posfr2 / purescript-node-fs-extra

A PureScript binding to fs-extra
Other
4 stars 1 forks source link

Upgrade to PureScript 0.15 #2

Open posfr2 opened 1 year ago

posfr2 commented 1 year ago

Hi, I believe I've created a fork with changes to get the package purescript-node-fs-extra to work under PureScript 0.15, which it currently doesn't.

Specifically, the "exports.unsafeRequireFS = require("fs-extra");" trick doesn't appear to work under PureScript 0.15.

I suspect that this is why the package is not included in Purescript 0.15 package set, which is a pity and is why I am taking this, for me, extraordinary initiative.

Hope you can work it out from here.

PS: I note that the module name in my Extra.Purs needs to be changed. Hope you can fix that too as all this git/gitHub stuff is overwhelming me.

rnons commented 1 year ago

Hi, I'm not using PureScript recently, you can do whatever you see fit. Thanks.

posfr2 commented 1 year ago

Thanks. Will do. Cheers

El sáb, 4 feb 2023 a las 18:00, Ping Chen @.***>) escribió:

Hi, I'm not using PureScript recently, you can do whatever you see fit. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/nonbili/purescript-node-fs-extra/issues/2#issuecomment-1416686671, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3B4TEVMTNCS7DOPXUD4I63WVYAR3ANCNFSM6AAAAAAUQ6CH5U . You are receiving this because you authored the thread.Message ID: @.***>

posfr2 commented 1 year ago

Hi Ping Chen, I joined Discord and posted a message seeking help in how best to proceed (ref: • Discord | "node-fs-extra" | PureScript https://discord.com/channels/864614189094928394/1074961243154165831). One suggestion given to me was that ""If you are interested in maintaining the repo then you can ask the original author to transfer the repo (better) or give you commit access to the repo. Then you can publish a new version of it with your changes added."

Would you be so kind as to transfer the repo to me, in which case I would be happy to maintain it, including updating it to 0.15 compatibility.

Regards, Franz

El dom, 5 feb 2023 a las 17:30, Franz Posaner @.***>) escribió:

Thanks. Will do. Cheers

El sáb, 4 feb 2023 a las 18:00, Ping Chen @.***>) escribió:

Hi, I'm not using PureScript recently, you can do whatever you see fit. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/nonbili/purescript-node-fs-extra/issues/2#issuecomment-1416686671, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3B4TEVMTNCS7DOPXUD4I63WVYAR3ANCNFSM6AAAAAAUQ6CH5U . You are receiving this because you authored the thread.Message ID: @.***>

rnons commented 1 year ago

Sure, it's possible I need to transfer to my personal account first, will transfer to you after that, thanks.

rnons commented 1 year ago

image Can you please rename your fork

posfr2 commented 1 year ago

Hi Ping Chen, Thank you for your ongoing assistance. I believe my repository has now been renamed to: posfr2/purescript-node-fs-extra0: A PureScript binding to fs-extra (github.com) https://github.com/posfr2/purescript-node-fs-extra0 - i.e. ending in extra0 instead of extra. Hope this achieves what you need. Regards, Franz

El mar, 14 feb 2023 a las 21:00, Ping Chen @.***>) escribió:

[image: image] https://user-images.githubusercontent.com/1082650/218709481-8f8965d5-383b-453a-8b81-8d801d8b664a.png Can you please rename your fork

— Reply to this email directly, view it on GitHub https://github.com/rnons/purescript-node-fs-extra/issues/2#issuecomment-1429492755, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3B4TETBTIXUZUJU7STCJ2DWXNNDPANCNFSM6AAAAAAUQ6CH5U . You are receiving this because you authored the thread.Message ID: @.***>

rnons commented 1 year ago

Still the same error, https://github.com/posfr2/purescript-node-fs-extra redirects to that repo. I'm afraid you need to remove your fork.

posfr2 commented 1 year ago

Hi Ping Chen, I believe that I have now deleted my fork. Regards, Franz

El mié, 15 feb 2023 a las 21:31, Ping Chen @.***>) escribió:

Still the same error, https://github.com/posfr2/purescript-node-fs-extra redirects to that repo. I'm afraid you need to remove your fork.

— Reply to this email directly, view it on GitHub https://github.com/rnons/purescript-node-fs-extra/issues/2#issuecomment-1431158623, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3B4TESKF6LBH3B4YTU7VZ3WXSZPBANCNFSM6AAAAAAUQ6CH5U . You are receiving this because you authored the thread.Message ID: @.***>