removeplugin is not calling remove-module - Githubissues

poshbotio / PoshBot

Powershell-based bot framework

MIT License

537 stars 108 forks source link

removeplugin is not calling remove-module #100

Closed gerane closed 6 years ago

gerane commented 6 years ago

When removing a plugin, remove-module is not being called. This means the module is not unloaded if a new version of the module is installed. Poshbot will be unable to properly detect imported commands

https://github.com/poshbotio/PoshBot/blob/master/PoshBot/Classes/PluginManager.ps1#L186

Expected Behavior

!rp should also call remove-module

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

run !rp
run !ip and install a newer version of the same module.

Context

Your Environment

Module version used:
Operating System and PowerShell version: 6.1 windows 10

devblackops commented 6 years ago

@gerane This should be fixed now with commit 787094ac62bb658e9865bde46fc8bbc60f3c31d4