ChrisLGardner
commented
6 years ago Would using [regex]::escape() be easier here so we don't need to maintain that list of special characters? We can just make it $prefix = [regex]::escape($prefix) and that should be all needed.
From: Joshua King notifications@github.com Sent: Thursday, October 11, 2018 1:53:57 AM To: poshbotio/PoshBot Cc: Subscribed Subject: [poshbotio/PoshBot] Adding array of special character, and escaping them (#125)
Description
Adding array of special character, and escaping them
Basically, some characters are regex special characters... '.' is a wildcard... so it was matching on literally everything. Adding an escape character (only when it's needed) allows the match to be literal.
Related Issue
This should fix issue #124https://github.com/poshbotio/PoshBot/issues/124.
Motivation and Context
Allows using desired prefix characters, such as .
. about
How Has This Been Tested?
Tested using standard (!) prefixes, and indicated issue prefix (.), and other random ones (a)
Also tested to ensure that string prefixes (bender) still work
Screenshots (if appropriate):
Testing with ! prefix
[test-]https://user-images.githubusercontent.com/6955786/46773852-0c30a500-cd5c-11e8-98d5-3efa1ac0671f.PNG
Testing with . prefix
[test-period]https://user-images.githubusercontent.com/6955786/46773863-12bf1c80-cd5c-11e8-81bb-8cac370a47ae.PNG
Types of changes
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- I have read the CONTRIBUTING document.
- I have added tests to cover my changes.
- All new and existing tests passed. (erm 45/53 passed, but they all failures seemed to be 'Path' related.)
You can view, comment on, or merge this pull request online at:
https://github.com/poshbotio/PoshBot/pull/125
Commit Summary
- Adding array of special character, and escaping them
File Changes
- M PoshBot/Classes/Bot.ps1https://github.com/poshbotio/PoshBot/pull/125/files#diff-0 (16)
Patch Links:
- https://github.com/poshbotio/PoshBot/pull/125.patch
- https://github.com/poshbotio/PoshBot/pull/125.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/poshbotio/PoshBot/pull/125, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQDqFrG1pdhIeyowjmonxiNIx3hkXc2gks5ujpalgaJpZM4XWlPU.
Windos
devblackops
Description
Adding array of special character, and escaping them
Basically, some characters are regex special characters... '.' is a wildcard... so it was matching on literally everything. Adding an escape character (only when it's needed) allows the match to be literal.
Related Issue
This should fix issue #124.
Motivation and Context
Allows using desired prefix characters, such as .
. aboutHow Has This Been Tested?
Tested using standard (!) prefixes, and indicated issue prefix (.), and other random ones (a)
Also tested to ensure that string prefixes (bender) still work
Screenshots (if appropriate):
Testing with ! prefix
Testing with . prefix
Types of changes
Checklist: