poshbotio / PoshBot

Powershell-based bot framework
MIT License
536 stars 108 forks source link

Adding #required modules to build.ps1 #180

Closed weq closed 4 years ago

weq commented 4 years ago

I added #requires to help people building the module. PSModuleVersions are from todays date, 11 october 2019. Will aid people to build from source more easily I suspect.

Description

Added the needed modules to compile, test, analyze etc the module with the build.ps1 script.

Motivation and Context

I got annoyed that I didn't have all the needed modules installed on a system. And instead of having to track down the proper modules I'd rather have the build script just tell me what I'm missing. Though it might not be the what you'd like to have contribute. Feel free to decline and throw away the PR as you see fit.

How Has This Been Tested?

Tested all build.ps1 tasks no errors.

Types of changes

Checklist:

weq commented 4 years ago

psake and / or several other modules might be "slightly" older than what I have ? Since the build failed at missing psake.

get-module platyps,pester,buildhelpers,psake | select name,version

Name         Version
----         -------
BuildHelpers 2.0.11
Pester       4.8.1
platyPS      0.14.0
psake        4.9.0
devblackops commented 4 years ago

@weq Thanks for the PR @weq but I don't think this is needed as there is already logic to install/import the required dependencies.

You can run the build script with the optional -Bootstrap switch. That will tell it to (install if not present) and run PSDepend to install any required dependencies that are defined in requirements.psd1. There should be no need for #requires.

./build.ps1 -Bootstrap -Task Test
weq commented 4 years ago

Oh well, the more I learn about building processes in PS and how we typically use them. :) thanks for learning something I'll rather utilize in my builds.