RamblingCookieMonster commented 7 years ago

When calling Get-CommandHelp, we check full command name, command, and aliases. A user would likely expect to run help against a command that runs, regardless of whether it is an alias or command name.

Intentionally used like. Still lets us match on unique command if user throws in a wildcard that happens to only bring back one command

Description

Details in #43

Related Issue

43

Motivation and Context

To improve poshbot-based help

How Has This Been Tested?

Manually tested.

help group

Matches group command only, with details - yay! (fixes #43)

help group*

Matches and command with group anywhere in it (previous behavior). Poshbot sees that more than one command comes back from group* command, appends * to start and end of filter. I'm iffy on this behavior now that I spell it out. Should we use -eq instead of -like?

help grou

Matches any command with grou anywhere in it (previous behavior).

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Depends what you classify previous behavior as : )

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Cheers!

devblackops commented 7 years ago

This looks good to me @RamblingCookieMonster. I ran some tests with !help and the behavior is as expected. Thanks!

Can you expand a little more on this?

I'm iffy on this behavior now that I spell it out. Should we use -eq instead of -like?

RamblingCookieMonster commented 7 years ago

Just that it feels odd that if I specify *group, or get*, my query will be modified to *group* and *get*, respectively.... but if we add different handling for cases where a user includes an asterisk, code will get ugly, I think?

I'm happy with it as is though, it's consistent with existing behavior

poshbotio / PoshBot

Adjust help filter to match exact first #46