search

poshsecurity / Posh-SYSLOG

Send SYSLOG messages from PowerShell
http://poshsecurity.com
MIT License
92 stars 19 forks source link

Support for TCP as transport protocol #6

Closed powershellshock closed 7 years ago

powershellshock commented 7 years ago

It would be great to add support for TCP in addition to UDP. Though TCP transport for syslog is not formally defined as a standard, it is widely supported by numerous solutions. RFC 6587, while not a standard describes how TCP has been used as a transport for syslog messages, which would enable us to develop this support.

powershellshock commented 7 years ago

I have already done most of the work to implement this by modifying the existing Send-SyslogMessage cmdlet. I have added some parameters to enable this and also modified existing ones, but created aliases to ensure backward compatibility. Please add me as a contributor, so that I may submit these changes for review. We may want to add a branch for this until the testing is more thorough. (As I said, the code is pretty much done already, but I think more testing and review is appropriate.)

kjacobsen commented 7 years ago

Hi Jared,

TCP support would be great, it has been something I have been thinking about for a while (but haven't had the need).

If you create a pull request, I can then work with you to review the changes and include them into the module.

powershellshock commented 7 years ago

Deleted my previous comments. (I am still learning GitHub and have now resolved my forking issues ;-) .) I will submit a pull request soon.

kjacobsen commented 7 years ago

Hi,

Reviewing the PR now.

I have created a new branch, version3, and will merge the PR into that first. From there I will work through any changes or tweaks that need to be made. Once that is complete, we will push into Master and then onto PowerShell Gallery.

I am going to increment the version number to 3.0.0 for these changes.

kjacobsen commented 7 years ago

I have just merged the version3 branch into master as part of #8