posicks / mdnsjava

Multicast DNS (mDNS) [RFC 6762] & DNS-Based Service Discovery (DNS-SD) [RFC6763] in Java
http://posicks.github.io/mdnsjava/
110 stars 43 forks source link

Shouldn't junit dependency in POM have test scope? #14

Open vvdleun opened 6 years ago

vvdleun commented 6 years ago

Hi,

I noticed my application bundles JUnit in its production JAR files. After looking around, I think it is caused by the POM file of mDNSJava:

<dependency>
    <groupId>junit</groupId>
    <artifactId>junit</artifactId>
    <version>4.12</version>
</dependency>

Shouldn't the "test" scope be specified here as well, or is there a reason for its compile scope?

Kind regards (and many thanks for your work on this awesome library!), Vincent