posimagi / bg-wiki-dark-mode

Issue tracker for Dark Mode on bg-wiki.com
1 stars 0 forks source link

Some/more KI pages need small adjustments #20

Closed ithorien closed 1 year ago

ithorien commented 1 year ago

Haven't gone ham, but it seems to affect all KI pages-

2023-04-20 15 46 33

TYTY! <3<3

posimagi commented 1 year ago

I have put in the CSS changes to fix this, need to wait for them to propagate through the cache before making the wikitext changes to apply the CSS.

posimagi commented 1 year ago

The following edit to Template:Key Item Header does not quite solve the issue. There is an outstanding CSS bug that needs to be addressed first.

<includeonly>{{#if: {{{Type|}}} | [[Category:{{{Type}}}]] | [[Category:{{{type}}}]] }}
__NOTOC__

{{#if: {{{Image|}}}|[[Image:{{{Image}}}|{{PAGENAME}}]]|[[Image:{{PAGENAME}}.jpg|{{PAGENAME}}]]}}
{{#if: {{{Image|}}}|{{#ifexist: Image:{{{Image}}}||[[Category:Need Key Item Image]]}}|{{#ifexist: Image:{{PAGENAME}}.jpg||[[Category:Need Key Item Image]]}}}}</includeonly>
{| class="BorderlessStandard keyitem" style="width: 100%; max-width: 788px; text-align: center;"
|-
! colspan="100%" height="34px" | 
{| style="width: 100%;" |
| style="width: 100%; text-align: center; padding 3px; background: #4b4d4f; color: #eeeeee;" | [[File:Key Item.png|link=]] Key Item Description <div style="float: right;">[[Image:{{BG_icon}} | link=:Special:WhatLinksHere/{{PAGENAME}} | Pages on this wiki that reference this item]]</div>
|}
|-
! colspan="100%" style="background: #9e9dff;" height=2px|
|-
! width="34%" | Type
! width="66%" | Description 
|-
| {{#if: {{{Type|}}} | [[:Category:{{{Type}}}{{!}}{{{Type}}}]] | [[:Category:{{{type}}}{{!}}{{{type}}}]] }}
| {{#if: {{{Description|}}} | {{{Description}}} | {{{description}}} }}
|-
|}<includeonly>[[Category:Key Items]]</includeonly>
<noinclude>[[Category:Templates/ItemPages|{{PAGENAME}}]]</noinclude>
posimagi commented 1 year ago

I'm still not sure why I can't get this one working correctly, it's currently the highest priority.

posimagi commented 1 year ago

Finally fixed the first table, which was the most egregious one. It had a pathological layout with embedded tables, now fixed. The others should be easier.

posimagi commented 1 year ago

Done!

image