search

posit-dev / ark

Ark, an R kernel
MIT License
159 stars 9 forks source link

Reticulate support #506

Closed dfalbel closed 6 days ago

dfalbel commented 3 weeks ago

Add support for reticulate sessions. See https://github.com/posit-dev/positron/pull/4603

lionel- commented 1 week ago

My main comment is about try_lock() which should be replaced by lock() to avoid rarely occurring surprising behaviour.

dfalbel commented 1 week ago

I addressed most points in https://github.com/posit-dev/ark/pull/506/commits/286a24aa0000ba736694dd133e9de117ba9d7d20

Also moved .ps.rpc.install_reticulate() into a more general .ps.rpc.install_packages.