search

posit-dev / ark

Ark, an R kernel
MIT License
159 stars 9 forks source link

support dotty assignments in diagnostics #511

Closed kevinushey closed 1 week ago

kevinushey commented 3 weeks ago

Closes https://github.com/posit-dev/positron/issues/4544.

Screenshot 2024-09-09 at 1 10 19 PM
github-actions[bot] commented 3 weeks ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

kevinushey commented 3 weeks ago

I have read the CLA Document and I hereby sign the CLA

kevinushey commented 3 weeks ago

We're going to move to a typed syntax API that will be easier to write and review, and to rowan for untyped nodes which will insulate us from tree-sitter.

I assume this tooling is still somewhat far down the line? If so I'd hope we can still take this in the interim since it's a relatively small + isolated change.

kevinushey commented 3 weeks ago

Test failure appears unrelated (but frightening):

Caused by:
  process didn't exit successfully: `/home/runner/work/ark/ark/target/debug/deps/data_explorer-9c0079d3ec061369` (signal: 11, SIGSEGV: invalid memory reference)
DavisVaughan commented 3 weeks ago

@kevinushey would you mind if I merged this in after doing the rest of the tree-sitter sync I'm currently working on? It touches the diagnostics file a lot and I think itll be easier to handle the conflicts by merging mine then laying in this on top