search

posit-dev / brand-yml

Unified branding with a single yaml file.
https://posit-dev.github.io/brand-yml/
MIT License
1 stars 0 forks source link

Make font default names uniform #5

Closed cscheid closed 3 months ago

cscheid commented 3 months ago

Currently, the spec has headings, but link. We should either have heading and link or headings and links. (I think it should be heading).

gadenbuie commented 3 months ago

Agreed, I noticed this yesterday. They're the names of Bootstrap's Sass variables (so it wasn't a random pluralization), but I'd rather we be internally consistent. Let's use heading.

cscheid commented 3 months ago

They're the names of Bootstrap's Sass variables (so it wasn't a random pluralization)

🤦 That's unfortunate.

I'm ok on heading, but that will confuse some people, and makes me want to change this less. I also wonder if we should allow either. Bootstrap is the "default" system in Quarto and Shiny both, and so I think it makes sense for us to follow its nomenclature. We already do with primary, secondary, etc.

gadenbuie commented 3 months ago

Technically, it's not a direct Sass variable, but a family of variables that start with $headings-, e.g. $headings-font-family, $headings-font-style, etc.

Which points out a good reason to keep headings plural: while base, link, and monospace apply to a single semantic element, typography.headings applies to a range of elements (<h1>, <h2>, <h3>, etc.). This also explains why size isn't included in the schema.

cscheid commented 3 months ago

Ok, that's persuasive to me. Thanks!