posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.44k stars 50 forks source link

Allow the 'transparent' color (and others) to be used in `tab_options(table_background_color == <color>)` #232

Closed rich-iannone closed 3 months ago

rich-iannone commented 4 months ago

This PR makes it possible for a GT table to have a transparent background by way of using the "transparent" color keyword. Previously, there would be an error because color values in _font_color() are routed through a webcolors function that only accepts CSS color names.

Fixes: https://github.com/posit-dev/great-tables/issues/230

machow commented 3 months ago

I don't understand why this PR also refactors away the data_color submodule, and am having trouble finding a summary of the big changes made in this PR. Can you provide a quick description of what big things you did in this PR and your thinking behind each one?

rich-iannone commented 3 months ago

Closing this in favor of https://github.com/posit-dev/great-tables/pull/242.