Closed machow closed 6 months ago
@rich-iannone do you mind picking this up when you get the chance?
@rich-iannone do you mind picking this up when you get the chance?
For sure! Thanks for going over all of this :)
Attention: Patch coverage is 70.58824%
with 10 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
main@54bffc4
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
great_tables/_formats.py | 18.18% | 9 Missing :warning: |
great_tables/_utils_nanoplots.py | 95.65% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rich-iannone todo:
pytest.raises
is being used to test something being raised.Ping when it's ready and we can get it merged!
LGTM--thanks for this, loving that sweet sweet test coverage!
This PR is for reviewing the nanoplots code, which we punted on in the name of getting it out the door!