posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.81k stars 60 forks source link

Refactor nanoplots #246

Closed machow closed 6 months ago

machow commented 6 months ago

This PR is for reviewing the nanoplots code, which we punted on in the name of getting it out the door!

machow commented 6 months ago

@rich-iannone do you mind picking this up when you get the chance?

rich-iannone commented 6 months ago

@rich-iannone do you mind picking this up when you get the chance?

For sure! Thanks for going over all of this :)

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@54bffc4). Click here to learn what that means.

Files Patch % Lines
great_tables/_formats.py 18.18% 9 Missing :warning:
great_tables/_utils_nanoplots.py 95.65% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #246 +/- ## ======================================= Coverage ? 75.26% ======================================= Files ? 41 Lines ? 4180 Branches ? 0 ======================================= Hits ? 3146 Misses ? 1034 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 6 months ago

@rich-iannone todo:

Ping when it's ready and we can get it merged!

machow commented 6 months ago

LGTM--thanks for this, loving that sweet sweet test coverage!