Closed rich-iannone closed 3 months ago
Attention: Patch coverage is 82.35294%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 75.26%. Comparing base (
cd618a4
) to head (ff69cb5
).
Files | Patch % | Lines |
---|---|---|
great_tables/_utils_nanoplots.py | 82.35% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In a previous PR, a call to
_generate_nanoplot()
was simplified to use**
to pass through args:https://github.com/posit-dev/great-tables/blob/cd618a4111b0f5206e412b522e2c50c06b2c9e8d/great_tables/_formats.py#L3832
However, the argument names in three cases don't match. These are:
line_type
!=data_line_type
show_ref_line
!=show_reference_line
show_ref_area
!=show_reference_area
The solution here is to expand the shorter arg names to their longer counterparts. This doesn't break the GT API since the longer names are what the user has access to within
nanoplot_options()
.With this change, examples in https://posit-dev.github.io/great-tables/blog/introduction-0.4.0/ should no longer be broken.