posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.81k stars 60 forks source link

Add several tests for different formatting methods #260

Closed rich-iannone closed 5 months ago

rich-iannone commented 6 months ago

Quite a few of the formatting methods had very low test coverage so this PR provides some testing for the following:

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.92%. Comparing base (d4178e0) to head (c9ff081).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #260 +/- ## ========================================== + Coverage 75.26% 79.92% +4.66% ========================================== Files 41 41 Lines 4180 4180 ========================================== + Hits 3146 3341 +195 + Misses 1034 839 -195 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rich-iannone commented 5 months ago

I believe all the comments have been addressed through the changes we made during code pairing. I handled a merge conflict and reformatted to satisfy the pre-commit error.