Missing `setuptools` dependency

daureg commented 6 months ago

Prework

[x] Read and agree to the code of conduct and contributing guidelines.
[x] If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.

Description

great tables imports pkg_resources but doesn't list setuptools as dependency.

Reproducible example

[x] Post a minimal reproducible example (MRE) so the maintainer can troubleshoot the problems you identify. A reproducible example is:
- [x] Runnable: post enough code and data so any onlooker can create the error on their own computer.
- [x] Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
- [x] Readable: format your code according to the Style Guide for Python Code.

Using uv to create the virtual environment because it doesn't include setuptools by default.

uv venv && source .venv/bin/activate && uv pip install great_tables && python3 -c "import great_tables"

Using Python 3.10.13 interpreter at: /home/glefalher/.pyenv/versions/3.10.13/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
Resolved 17 packages in 16ms
Installed 17 packages in 27ms
 + babel==2.14.0
 + commonmark==0.9.1
 + great-tables==0.4.0
 + htmltools==0.5.1
 + importlib-metadata==7.1.0
 + mizani==0.11.1
 + numpy==1.26.4
 + packaging==24.0
 + pandas==2.2.1
 + python-dateutil==2.9.0.post0
 + pytz==2024.1
 + scipy==1.13.0
 + six==1.16.0
 + typing-extensions==4.11.0
 + tzdata==2024.1
 + webcolors==1.13
 + zipp==3.18.1

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/glefalher/nwork/gtpkg2/.venv/lib/python3.10/site-packages/great_tables/__init__.py", line 10, in <module>
    from .gt import GT
  File "/home/glefalher/nwork/gtpkg2/.venv/lib/python3.10/site-packages/great_tables/gt.py", line 15, in <module>
    from great_tables._formats import (
  File "/home/glefalher/nwork/gtpkg2/.venv/lib/python3.10/site-packages/great_tables/_formats.py", line 20, in <module>
    from ._locale import _get_locales_data, _get_default_locales_data, _get_currencies_data
  File "/home/glefalher/nwork/gtpkg2/.venv/lib/python3.10/site-packages/great_tables/_locale.py", line 4, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

Expected result

great_tables should be importable

Development environment

Operating System: [e.g., Linux, macOS, Windows]
great_tables Version: 0.4.0
uv 0.1.26

Additional context

The same example works when using python to create the virtual enviroment

python3 -m venv venv && source venv/bin/activate && python3 -m pip install -U great_tables && python3 -c "import great_tables"

According to the doc:

Use of pkg_resources is deprecated in favor of :mod:importlib.resources, :mod:importlib.metadata and their backports (:pypi:importlib_resources, :pypi:importlib_metadata).