search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.43k stars 48 forks source link

fix: remove uses of DataFrame.apply and dtype methods #277

Closed machow closed 2 months ago

machow commented 2 months ago

This PR removes some lingering uses of DataFrame methods outside of our DataFrame specific _tbl_data.py submodule. It also restricts the columns= argument of .fmt_nanoplot() to be a string for now, as this seemed to be the only supported path.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.71%. Comparing base (ed09f9d) to head (3efa020).

Files Patch % Lines
great_tables/_formats.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ========================================== - Coverage 81.72% 81.71% -0.02% ========================================== Files 41 41 Lines 4323 4325 +2 ========================================== + Hits 3533 3534 +1 - Misses 790 791 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.