Closed jrycw closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.71%. Comparing base (
479eb73
) to head (7008372
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks so much for this work! I'm pairing right now with @rich-iannone, and he mentioned this function should always return hex (which it wasn't even before this PR). I've tweaked it a bit, so that when things like "transparent" are passed, hex colors are output.
The refactored code looks better. In fact, the variable names definitely represent their meaning clearly.
It appears we're having an issue with the Table Theme Options -> Set options across table parts section.
The problem seems to arise when color values are input using common names like
yellow
orwhite
, causing thefont_color
not to transform them into the appropriate hexadecimal format.To address this issue, I've implemented a conversion pattern similar to the one used in
font_color
, which should hopefully resolve the issue.Additionally, I noticed quick returns in the first few lines of
font_color
. I'm uncertain whether these also need conversion. Could the team please review this aspect?