Code refactoring in `_tbl_data`

posit-dev / great-tables

Make awesome display tables using Python.

https://posit-dev.github.io/great-tables/

MIT License

1.43k stars 48 forks source link

Code refactoring in `_tbl_data` #288

Closed jrycw closed 2 months ago

jrycw commented 2 months ago

Hello team,

I wanted to express my gratitude for creating this fantastic library. However, I believe there's always room for improvement. I've taken a look around the codebase and identified some areas where we could refactor or simplify certain logics. I'm curious to know if you would welcome this kind of PR?

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.71%. Comparing base (479eb73) to head (1889697).

Files	Patch %	Lines
great_tables/_tbl_data.py	0.00%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #288 +/- ## ======================================= Coverage 81.71% 81.71% ======================================= Files 41 41 Lines 4325 4325 ======================================= Hits 3534 3534 Misses 791 791 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 2 months ago

Hey, thanks so much for all these PRs. This particular one is a bit tricky, since it needs to maintain backwards compatibility with earlier polars versions. I've left some comments, on how the code changes could hit issues (compared to the original code).

We're super excited for all your contributions, and appreciate you looking through. I'm going to close this specific PR, but just know that we really appreciate all these contributions you're making

jrycw commented 2 months ago

@machow Thanks for your detailed explanation. I think that's the reason the code looks so familiar to me. It seems that I've made a similar error a few months ago. I've left two comments that might be beneficial for this code in the PR. Would you mind taking a look?