posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.43k stars 48 forks source link

Refactor `letters` and `Letters` functions in `_helpers` #289

Closed jrycw closed 2 months ago

jrycw commented 2 months ago

I recommend utilizing the built-in string module to define the letters and Letters functions.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (479eb73) to head (4b83b59).

Files Patch % Lines
great_tables/_helpers.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ========================================== + Coverage 81.71% 81.72% +0.01% ========================================== Files 41 41 Lines 4325 4324 -1 ========================================== Hits 3534 3534 + Misses 791 790 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.