posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.43k stars 48 forks source link

epic: Remove numpy as a dependency #296

Open machow opened 2 months ago

machow commented 2 months ago

Currently, we use numpy in two places:

Note that for replacing numpy in performing calculations, we should be careful to ensure tests are in place / added where needed. We have good coverage, but I'm not sure it covers every numpy path.

jrycw commented 2 months ago

It seems that numpy is also utilized in some tests. Should we consider removing it from testing as well?

machow commented 2 months ago

It seems okay to keep it around in tests. Since pandas can wrap numpy, and return numpy typed objects, we might need it in tests to validate that functions do the right things for a few numpy objects (which might make it in via pandas, etc..)