search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.43k stars 48 forks source link

ci: test on a windows runner #300

Closed machow closed 1 month ago

machow commented 2 months ago

This PR addresses potential issues when using GT.save() on a windows machine. It removes an unnecessary tmp dir being used when initiating NamedTemporaryFile (which could cause bizarreness), and adds a windows runner to our CI.

Edit: let's push fine-tuning to https://github.com/posit-dev/great-tables/pull/276, which uploads saved table images as artifacts in our CI.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.71%. Comparing base (14ce2c5) to head (40587a8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #300 +/- ## ========================================== - Coverage 81.71% 81.71% -0.01% ========================================== Files 41 41 Lines 4321 4320 -1 ========================================== - Hits 3531 3530 -1 Misses 790 790 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 2 months ago

Okay, the remaining test failures are all related to paths in our fmt_image snapshot tests!