search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.43k stars 48 forks source link

Codebase cleanup and minor improvements #305

Closed jrycw closed 2 months ago

jrycw commented 2 months ago

This PR primarily focuses on cleaning up our codebase, largely based on the discussion in #302. However, during my review of the code, I also identified several minor areas for improvement, which I've addressed in this PR.

These modifications may contain some subjective changes. I kindly ask the team to review them based on your judgment. Any feedback or comments would be greatly appreciated.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 81.88%. Comparing base (0f0c024) to head (3c13937).

Files Patch % Lines
great_tables/_options.py 37.50% 5 Missing :warning:
great_tables/_utils.py 20.00% 4 Missing :warning:
great_tables/_formats.py 83.33% 1 Missing :warning:
great_tables/_styles.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #305 +/- ## ========================================== + Coverage 81.66% 81.88% +0.21% ========================================== Files 41 41 Lines 4276 4256 -20 ========================================== - Hits 3492 3485 -7 + Misses 784 771 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rich-iannone commented 2 months ago

Thank you @jrycw for all the work done in this PR! Will be merging this now.