Closed machow closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.45%. Comparing base (
14ce2c5
) to head (95898fc
). Report is 59 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rich-iannone I feel like I still need to do a clean up pass, but would love to get your feedback!
@machow I just read through it and it flows wonderfully. It was an interesting read as well, with just the right length of material.
I don’t think any of the content needs to be changed at all. Let me know if you’d like me to proofread after your next round of edits!
Shoot, I forgot to mention one possible change. We don’t actually use webcolors
to translate color names to hexadecimal color codes (we have a dictionary for that). And we are probably going to remove that small dependency according to https://github.com/posit-dev/great-tables/issues/282.
Given all this, could you find another example of a small dependency we use in the package?
We don’t actually use webcolors
Ah, thanks for catching---I'll take it out, and leave the Babel example (if it looks accurate)!
I added a few take-it-or-leave-it suggestions. These are mostly fixes for naming consistency.
@rich-iannone okay I think it might be ready to go. Do you want to merge / flag anything?!
There’s one more thing: change the publication date to today’s. Then it’s ready to go!
This PR adds a blog post on how we made pandas an optional dependency in v0.5.0.
Note: