Open timkpaine opened 1 month ago
Hey, thanks for this incredibly comprehensive PR! At first I was nervous about the idea of a PR implementing all locations at once, but after seeing your changes, it seems very reasonable! Happy to kick the tires, help with anything :)
Here's my quick attempt at mapping the Loc names here, to those used in the R library gt:
It seems like you may have surfaced two important things:
StyleInfo(loc="some_string")
It seems like defining all Loc sub-locations might also let us replace things like StyleInfo(loc="footnotes")
with StyleInfo(loc=loc)
, where loc
is the LocFootnotes object itself. Replacing all the string checks with isinstance would make it very easy to find references to Loc classes in VS Code, etc..!
In any event, this is looking really great! Thanks for this huge effort---I'm happy to check anything, do anything to support!
Summary
This is a work-in-progress PR for allowing more granular styling of the various components via the API currently used for cell styling (e.g.
loc.body()
). The motivation is that it's often desired to style e.g. all column labels at once. It looks like this was already started in part (there are many TODOs such as these).This PR is nowhere near done yet, so please don't approve CI running (it will just make noise).
Early Example:
Checklist