posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.42k stars 48 forks source link

fix: ensure export() always captures full table #344

Closed machow closed 1 month ago

machow commented 1 month ago

This PR refactors the GT.save() function to be a bit more robust, by...

This PR supercedes (aka cribs) the best parts of...

This PR should resolve...

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 61.66667% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 83.10%. Comparing base (7eae1f2) to head (28f8cf8).

Files Patch % Lines
great_tables/_export.py 61.01% 23 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #344 +/- ## ========================================== - Coverage 83.51% 83.10% -0.42% ========================================== Files 41 41 Lines 4308 4338 +30 ========================================== + Hits 3598 3605 +7 - Misses 710 733 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 1 month ago

Woof--I think it's working! See exported table save artifact here!

https://github.com/posit-dev/great-tables/actions/runs/9102189412/artifacts/1506782484

rich-iannone commented 1 month ago

This is incredibly awesome! My only suggestion: take Pillow out of pyproject.toml.

machow commented 1 month ago

It's tucked away in extra installs, so hopefully shouldn't be too bad?! I'm going to merge, but can open a new PR for that if useful!