Test use of polars selectors throughout library

posit-dev / great-tables

Make awesome display tables using Python.

https://posit-dev.github.io/great-tables/

MIT License

1.82k stars 61 forks source link

Test use of polars selectors throughout library #35

Open machow opened 10 months ago

machow commented 10 months ago

Related to https://github.com/posit-dev/great-tables/pull/34, I've implemented the path for using polars selectors, but need to add more tests of its usage. It seems like aspects of selection can be consolidated in places (e.g. the handling of columns in the cols_* functions).

Most functions that take a selection argument do a bit of custom checking, and these checks seem largely the same across functions..!

machow commented 10 months ago

To check:

select via scalar (e.g. "some_col")
select via list
select via polars
select via lambda
(what should happen on a list of polars selectors?)