search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.42k stars 48 forks source link

fix: issue with `_save_screenshot()` #352

Closed jrycw closed 1 month ago

jrycw commented 1 month ago

It seems that we need to use f.read() to avoid the TypeError: a bytes-like object is required, not '_io.BufferedReader'.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.90%. Comparing base (6b2624b) to head (c0ea247).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #352 +/- ## ========================================== + Coverage 85.74% 85.90% +0.16% ========================================== Files 41 41 Lines 4328 4328 ========================================== + Hits 3711 3718 +7 + Misses 617 610 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 1 month ago

Merged in main so we could re-run tests