search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.42k stars 47 forks source link

Add python 3.8 support; #383

Open schloerke opened 1 week ago

schloerke commented 1 week ago

great-tables should support the same versions of supported python versions as in https://devguide.python.org/versions/#supported-versions

Today, this is python 3.8+ (not python 3.9+).

machow commented 1 week ago

Hey--we are currently following NEP 29, but will likely switch to the devguide in the future (since it seems like Polars is also following this).

Since the EOL of 3.8 is close, it seems okay to close for now, and use the devguide for future EOL guidance (e.g. on deciding when to drop 3.9). @rich-iannone, WDYT?

schloerke commented 1 week ago

If py-shiny is adopting great-tables within a couple weeks for data frame usage, I'd like to advocate for 3.8 support in great-tables.

machow commented 1 week ago

Are you planning to add great-tables as a hard dependency? If shiny is just adding the ability to handle a GT object, then at the point it receives one, you'll know the person is on python 3.9+. (here's how we marked it in the polars requirements file: https://github.com/pola-rs/polars/blob/main/py-polars/requirements-dev.txt#L56)