posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.42k stars 48 forks source link

fix: show no longer raises or prints to stderr #384

Closed machow closed 1 week ago

machow commented 1 week ago

This PR addresses https://github.com/posit-dev/great-tables/issues/381, by...

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (813f3f3) to head (3debae6).

Files Patch % Lines
great_tables/_export.py 66.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #384 +/- ## ========================================== - Coverage 86.52% 86.52% -0.01% ========================================== Files 42 42 Lines 4594 4592 -2 ========================================== - Hits 3975 3973 -2 Misses 619 619 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 1 week ago

@rich-iannone do you mind trying this locally, in a notebook and then in the IPython repl?

from great_tables import GT, exibble

GT(exibble).show()

from the repl it should open in the browser (and not raise an error afterward).