posit-dev / great-tables

Make awesome display tables using Python.

https://posit-dev.github.io/great-tables/

MIT License

1.42k stars 48 forks source link

bug(polars): fix fmt_percent issue with polars-u64-idx #388

Open lostmygithubaccount opened 2 days ago

lostmygithubaccount commented 2 days ago

Summary

drive-by attempt at solving the issue I created. I'm sure there's a cleaner way to write this, but it unblocks me. feel free to push to this PR/request changes/close in favor of a better solution!

Related GitHub Issues and PRs

Ref: #387

closes #387

Checklist

[x] I understand and agree to the Code of Conduct.
[x] I have followed the Style Guide for Python Code as best as possible for the submitted code.
[ ] I have added pytest unit tests for any new functionality.

machow commented 8 minutes ago

IMO this can only help :p. Do you mind giving a little context on how a person gets to this polars install? (Do you install with a flag, or install a special pypi package?).

@rich-iannone do you mind reviewing? (seems okay to me, since it's a fallback behavior)

edit: oh wait, I see from the issue it's from installing https://pypi.org/project/polars-u64-idx/ . seems like into okay fix for now imo