Open minimav opened 4 months ago
Attention: Patch coverage is 83.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 86.64%. Comparing base (
f8e30ea
) to head (f1df81e
).
Files | Patch % | Lines |
---|---|---|
great_tables/_formats.py | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary
This PR fixes a bug whereby values from unselected rows affect the scaling in nanoplots. In addition to the single values case given in #283, a simple example of the bug in the context of multiple values per row is below (when
autoscale
is used):Single values example post-fix:
Multiple values example post-fix:
I have added a couple of unit tests based on existing ones, let me know if they work. Thanks for your work on this library, I have been using it at work and really enjoying it 🙂
Related GitHub Issues and PRs
Checklist