Closed minimav closed 1 month ago
Seconding this need. I use Firefox installed with snap (which is awful but this is my Ubuntu work PC and it came like that), and it requires some specific setup for Selenium, which cannot be achieved currently.
Extending the web_driver
argument makes sense to me -- I can work on a PR to implement
This should be supported in v0.13.0 (releasing now!)
Great, thanks!
Prework
Proposal
When saving a table currently the options for the the web driver that selenium uses are strings found here, for which some default options are set within the
save
function. In some situations it is helpful to allow further customisation of the web driver e.g. I was trying to save a table from within a Docker container where even with a browser installed in the Docker image correctly (Chrome in my case), I needed to add extra web driver options in order to get saving to work.There are a couple of ways in which you could add such functionality:
web_driver
kwarg alongside the current string options which result in the default options being used, i.e. pass in an object likewdriver(options=wd_options)
that is created here in thesave
functionwd_options.add_argument(...)
There will likely be other ways of achieving the same outcome too.
I'd be happy to work on a PR for this if you think this is a good addition. Cheers :)