posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.9k stars 72 forks source link

Allow custom web driver (options) when saving #416

Closed minimav closed 1 month ago

minimav commented 3 months ago

Prework

Proposal

When saving a table currently the options for the the web driver that selenium uses are strings found here, for which some default options are set within the save function. In some situations it is helpful to allow further customisation of the web driver e.g. I was trying to save a table from within a Docker container where even with a browser installed in the Docker image correctly (Chrome in my case), I needed to add extra web driver options in order to get saving to work.

There are a couple of ways in which you could add such functionality:

There will likely be other ways of achieving the same outcome too.

I'd be happy to work on a PR for this if you think this is a good addition. Cheers :)

thuiop commented 1 month ago

Seconding this need. I use Firefox installed with snap (which is awful but this is my Ubuntu work PC and it came like that), and it requires some specific setup for Selenium, which cannot be achieved currently.

machow commented 1 month ago

Extending the web_driver argument makes sense to me -- I can work on a PR to implement

machow commented 1 month ago

This should be supported in v0.13.0 (releasing now!)

thuiop commented 1 month ago

Great, thanks!