search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.9k stars 72 forks source link

Improve test coverage for `test_options.py` #437

Closed jrycw closed 2 months ago

jrycw commented 2 months ago

This PR aims to improve the test coverage for test_options.py. I hope it helps!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.68%. Comparing base (e877444) to head (5cb1de1). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #437 +/- ## ========================================== + Coverage 86.37% 86.68% +0.30% ========================================== Files 42 42 Lines 4683 4685 +2 ========================================== + Hits 4045 4061 +16 + Misses 638 624 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machow commented 2 months ago

@rich-iannone do you want to glance over / merge?

rich-iannone commented 2 months ago

Thanks @jrycw ! This is a good refactor and the additional test coverage helps a lot :) I'll merge now.