search

posit-dev / great-tables

Make awesome display tables using Python.
https://posit-dev.github.io/great-tables/
MIT License
1.9k stars 71 forks source link

Update `_save_screenshot()` to use `WebElement.screenshot_as_png` #459

Closed jrycw closed 1 month ago

jrycw commented 1 month ago

I was wondering if _save_screenshot() could be improved by directly utilizing WebElement.screenshot_as_png.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.76%. Comparing base (b14c8f2) to head (f79e7e6). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #459 +/- ## ========================================== - Coverage 86.77% 86.76% -0.02% ========================================== Files 42 42 Lines 4749 4745 -4 ========================================== - Hits 4121 4117 -4 Misses 628 628 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.