Closed jrycw closed 3 days ago
Attention: Patch coverage is 91.52542%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 89.38%. Comparing base (
1ad3ec1
) to head (23f12cb
). Report is 14 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
great_tables/_utils_selenium.py | 90.90% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Hello team,
In my last commit, I experimented with isolating the web driver preparation logic into _utils_selenium.py
. Please feel free to review and decide whether to keep or discard this change.
This is looking good! I had a look at the output images on all 4 webdrivers (at 3 different scale values) to make sure outputs are similar to main
. In case this is interesting I've included the images in this zip file:
I've found no reduction in quality with the changes here. Chrome is the only one that is problematic (cuts off content at the bottom) but that's also on main
and an open issue anyway.
This is looking good! I had a look at the output images on all 4 webdrivers (at 3 different scale values) to make sure outputs are similar to
main
. In case this is interesting I've included the images in this zip file:I've found no reduction in quality with the changes here. Chrome is the only one that is problematic (cuts off content at the bottom) but that's also on
main
and an open issue anyway.
As a side note, this PR does not address the cutoff bug encountered when using Chrome, as mentioned in #480 .
Shoot, I just noticed the change to passing a base64 encoded url directly to the headless browser. I think there could be some challenges with this approach (and url length limitations). In general, modern browsers seem to have large limits, but it's a tricky territory.
Opened an issue to track:
Related PR: #496.
This PR introduces several improvements to enhance the usability of
GT.save()
:**params
to allow advanced users to customize save parameters directly via Pillow..png
extension check to a single line.FmtImage._get_image_uri()
, without usingtempfile.TemporaryDirectory()
.time.sleep(0.05)
withWebDriverWait(driver, 1).until()
(we may need to determine the optimal timeout for most use cases)..png
saving branch that relied onselenium
; all files are now saved usingPillow
.GT.save()
to return itself, allowing users to save intermediate tables. For example:Additionally, I noticed a potential speed boost (approximately 40-50% faster on my machine) when calling
headless_browser=wdriver(options=wd_options)
directly, bypassing the context manager. However, I'm unsure about the safety implications of this approach.