posit-dev / positron

Positron, a next-generation data science IDE
Other
2.57k stars 79 forks source link

"Insert Chunk" keyboard shortcut not splitting chunks in Quarto notebook when line in existing chunk is selected #1330

Closed ntentes closed 8 months ago

ntentes commented 1 year ago

Positron Version:

Positron Version: 2023.09.0 (Universal) build 151 Code - OSS Version: 1.79.0 Commit: b10765299bc72351d4a3da48e53a8c09bd2cb14c Date: 2023-09-18T02:47:09.360Z Electron: 22.3.10 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.6.0

Steps to reproduce the issue:

In RStudio notebooks, if you press command + option + I when a line outside of a chunk is selected, a chunk is inserted. Pressing the same when a line in the middle of a chunk is selected, it splits the chunk into two chunks at the selected line.

In Positron notebooks, pressing command + shift + I will select the line under the chunk, insert a new line and then insert a new chunk.

I'm assuming this was not intentional because I couldn't find a "split chunk" shortcut, but I'm happy to be corrected here.

What did you expect to happen?

I expected Positron to split the chunk when using the insert chunk shortcut when a line in a chunk is selected.

Were there any error messages in the output or Developer Tools console? No.

jmcphers commented 1 year ago

@EmilHvitfeldt also hit this (see #1509)

juliasilge commented 8 months ago

This behavior is from the Quarto VS Code extension, and I logged the issue here: https://github.com/quarto-dev/quarto/issues/382