Closed isabelizimm closed 4 weeks ago
@isabelizimm I imagine these were all tested prior to the switchover to the later version of html-manager, it might be worth us re-testing to see whether there are any changes in what works/what doesn't after the update -- we should also specify here the module version of the above widget types that we tested, since we know now that makes a difference to whether it's compatible or not
In order to support matplotlib widgets and others that require a live Python kernel, we need to enable an actual non-stubbed RendererContext
.
and stubbed RendererContext https://github.com/posit-dev/positron/blob/aa6476a862089ffa5b720ef37ca14f40bf175278/src/vs/workbench/contrib/positronOutputWebview/browser/notebookOutputWebviewServiceImpl.ts#L208-L219
Also see how this gets handled for ipywidgets in the jupyter extension https://github.com/microsoft/vscode-jupyter/blob/4ca00b28cf3b890593e9c84d73b65e67f51a8061/src/webviews/webview-side/ipywidgets/renderer/index.ts#L244-L257
Does this cover plotly / bokeh plots?
@peekxc I believe that plotly works:
Are you observing something different?
For bokeh, I do not believe we have that working correctly right now (the plot opens in an external browser).
For bokeh, I do not believe we have that working correctly right now (the plot opens in an external browser).
Ahh, I was talking about bokeh; sorry, I assumed the behavior would be identical
https://github.com/posit-dev/positron/pull/4172 and https://github.com/posit-dev/positron/pull/4208 should get the following widgets working:
anywidget
bqplot
drawdata
ipydatagrid
ipyleaflet
ipympl
ipytree
ipywidgets
– all widget types except Output
which needs special handlingpythreejs
There may be smaller issues with those, which we can log separately.
I haven't yet figured out why ipycanvas
isn't working.
Positron Version(s) : 2024.08.0-24
OS Version : OSX
Validated with everything here: https://gist.github.com/isabelizimm/02f7ba16dc74b202935f6d3e9ed6b892 Everything looks good except ipycanvas, which is noted above
Link(s) to TestRail test cases run or created: N/A
Once #1918 is merged, we will have basic support for the widgets such as ipywidgets, ipydatagrid, and ipyleaflet in the plot pane. Still not working ❌ is:
Here is a gist of all the different widgets, for testing purposes
CC: @jgutman