Positron Version: Server About dialog shows outdated information

posit-dev / positron

Positron, a next-generation data science IDE

https://positron.posit.co

Other

2.78k stars 85 forks source link

Positron Version: Server About dialog shows outdated information #2059

Open jmcphers opened 10 months ago

jmcphers commented 10 months ago

To reproduce, open the Command Palette in Positron Server and run the Help: About command.

This information is very outdated; it should show the current version of Positron and VS Code (currently 2024.01 and 1.85 respectively)

jmcphers commented 10 months ago

This seems to be an artifact of running in dev server mode. In particular the 1.82 value is coming from Code - OSS upstream!

https://github.com/posit-dev/positron/blob/84ade739a7025cac53a04206a68077f71729b847/src/vs/platform/product/common/product.ts#L52-L63

Ideally we'd get this from the product JSON file as that's where the About dialog gets them on Electron builds. It's not immediately clear to me why that doesn't happen in server mode.