search

posit-dev / positron

Positron, a next-generation data science IDE
Other
2.51k stars 79 forks source link

Data Explorer rendering on scroll is extremely slow/ doesn't work with moderately large datasets #2210

Closed jgutman closed 7 months ago

jgutman commented 8 months ago

Using Positron 2024.02.0 +1510, open the data tool with a pandas dataset of a moderate to large size. I used the Bluebook builder's training and validation dataset, which has 412,698 rows and 53 columns.

https://github.com/posit-dev/positron/assets/7817881/a3ca11ed-b1e6-449d-a6d7-b2bab4a4c8fb

Attempting to scroll in the data tool renders the data tool unusable. With slow scrolling, we can see rows rendering one by one, but if we scroll normally, we basically just get an empty data tool with no data rendered

jgutman commented 8 months ago

I think this is mostly addressed by https://github.com/posit-dev/positron/pull/2209

wesm commented 7 months ago

@jgutman when you have a chance, can you verify that things are good in main now so we can close this?

jgutman commented 7 months ago

Verified now. With large datasets scrolling and caching now works as expected. There is a brief blank screen as the fetch requests are resolved, and I wonder whether we should have some kind of loading indicator instead of just the blank grid, but it resolves within a few hundred milliseconds so perhaps we think we don't need one.

wesm commented 7 months ago

I think @softwarenerd plans to add a spinner or some gray CSS state that suggests that data is loading. I created https://github.com/posit-dev/positron/issues/2301