posit-dev / positron

Positron, a next-generation data science IDE
Other
2.57k stars 79 forks source link

View plot in editor space #2270

Closed timtmok closed 1 month ago

timtmok commented 8 months ago

Add a way to allow a user to view a plot as an editor. This allows a larger view without altering the size of the plots pane and leverages the editor's ability to float as its own window or tile along other editors/plots.

jmcphers commented 6 months ago

Requested (more or less) by beta user: https://github.com/posit-dev/positron-beta/discussions/122

juliasilge commented 4 months ago

I have been doing some prep for teaching a workshop, and I really want this feature.

jmcphers commented 3 months ago

Relevant Mastodon thread:

The only weird thing is no zoom option for plotting.

https://mastodon.online/@rmflight@mastodon.social/112695382560885990

seeM commented 3 months ago

Sort of requested in https://github.com/posit-dev/positron/issues/3884.

nstrayer commented 3 months ago

I think as long as we have a really good encapsulation of the IPositronPlotClient class it should be relatively straightforward to write an EditorPane/EditorInput class that can act as the front-end.

Work done for #1713 will probably make this easier as it will involve making the front-end as stateless as possible.

factorialmap commented 3 months ago

In RStudio there is a very useful option to show data/plots/viewer/console without having to split panels, it just expands the panels using shortcut keys.

Tools>Modify Keyboard Shortcuts>Zoom. It's really fast.

I think it might be really cool if we had that on the Positron.

https://github.com/user-attachments/assets/5051bd09-7b7c-4bb9-9bb1-47e711d00640

juliasilge commented 1 month ago

I'll start some QA notes for the initial version of this! 🎉

QA Notes

testlabauto commented 1 month ago

Verified Fixed

Positron Version(s) : 2024.09.0-27
OS Version          : OSX

Test scenario(s)

Open in editor works well. No controls yet in editor I assume is expected.

Link(s) to TestRail test cases run or created: N/A