Refine the color decorators scope

posit-dev / positron

Positron, a next-generation data science IDE

https://positron.posit.co

Other

2.75k stars 82 forks source link

Refine the color decorators scope #2315

Open jennybc opened 8 months ago

jennybc commented 8 months ago

Splitting this out from #1613. The original topic there is a feature request (that github issue numbers be auto-linked in NEWS.md).

However that provoked much discussion of generally over-eager color decoration in Positron. Some of this may be inherited from VS Code, but some of it may be due to choices we've made. See #1613 for more discussion.

This issue is for the more limited, more bug-fix-y issue of suppressing inappropriate color decoration.

jennybc commented 8 months ago

From the other thread, here's an example of over-eager color decoration. An issue number should not be decorated with a color picker when authoring a commit message and this appears to affect Positron but not VS Code. Screenshot from other thread, but I can also reproduce the behaviour in Positron Version: 2024.02.0 (Universal) build 1567. And in VS Code Version: 1.86.1, this doesn't happen in a git commit message. So it's something we've done.

jennybc commented 8 months ago

If we don't fix this, maybe we can frame this as Positron's synesthesia feature, which associates certain colors with your GitHub issues 🌈