search

posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.73k stars 82 forks source link

Cannot fully uncomment roxygen comments with shortcut #2556

Open JosiahParry opened 7 months ago

JosiahParry commented 7 months ago

Positron Version:

Build 1169

Steps to reproduce the issue:

  1. Create roxygen comments e.g. #' This is a comment
  2. Cmd + shift + / to uncomment
  3. observe that ' remains

What did you expect to happen?

I expected #' to be removed

Were there any error messages in the output or Developer Tools console?

DavisVaughan commented 7 months ago

Oh that is annoying, I will promote that to an issue in the private repo

jennybc commented 6 months ago

This is pretty maddening. I'm going to promote to Release Candidate.

DavisVaughan commented 6 months ago

I don't know an immediate way to fix it because you can only have one line comment https://github.com/posit-dev/positron/blob/2d5b6ee8b11890d5176f25c37588f76354db3992/extensions/positron-r/language-configuration/r-language-configuration.json#L3

DavisVaughan commented 6 months ago

Used here: https://github.com/posit-dev/positron/blob/2d5b6ee8b11890d5176f25c37588f76354db3992/src/vs/editor/contrib/comment/browser/lineCommentCommand.ts#L91-L92

juliasilge commented 1 month ago

Here is the feature request on the VS Code repo to support more than one: https://github.com/microsoft/vscode/issues/64659