search

posit-dev / positron

Positron, a next-generation data science IDE
Other
2.52k stars 79 forks source link

Clarify boolean algebra for AND / OR filters on Data Explorer #3058

Open juliasilge opened 5 months ago

juliasilge commented 5 months ago

Related to #2984

If you have a combination of AND and OR filters in the Data Explorer:

https://github.com/posit-dev/positron/assets/12505835/4a705d1f-e199-48b7-9a3b-a2f973d2686f

the UI is ambiguous about what is going on, since for example (F1 AND F2) OR F3 is not the same as F1 AND (F2 OR F3). The UI should be more clear about what is going on, or we should only allow all AND or all OR filters, or similar.

IMO this is quite high priority and worth fixing before public beta.

jthomasmock commented 5 months ago

@softwarenerd -- would it be possible to have switching between and/or globally affect all of the filters?

wesm commented 5 months ago

Currently it's left-to-right evaluation with no parenthesization. I'm not sure what we could do in terms of a UI treatment to make it clear that that is what's going on -- seems like that would be the best thing if there was some way to make that clear. To make it globally one or the other would be a small loss of functionality, but having unclear behavior isn't good either.

wesm commented 5 months ago

We discussed this today and the consensus is we can just remove the OR filter option for the time being and await feedback from beta users.