posit-dev / positron

Positron, a next-generation data science IDE
Other
1.19k stars 32 forks source link

Guard against potential quotes surrounding `R_HOME_DIR` path #3704

Closed DavisVaughan closed 1 day ago

DavisVaughan commented 4 days ago

Addresses https://github.com/posit-dev/positron/issues/3696

We aren't sure why, but that particular custom install of R on Linux had R_HOME_DIR="<path>" with literal " double quotes. We haven't seen that elsewhere, normally its just a "bare" path. That causes our downstream path generation to break.

I can't seem to figure out why R would generate it this way (from looking at the sources here: https://github.com/wch/r-source/blob/9d01d16b4cda7b53b9a2c94a1e3f078faf1b9eaa/src/scripts/Makefile.in#L79), but I figure it is best for us to guard against the possibility of it by removing them.

Tested this myself by manually adjusting my R shell script to include " quotes in the R_HOME_DIR path, noted that it did break Positron, applied the patch and retested and it worked.