search

posit-dev / positron

Positron, a next-generation data science IDE
Other
1.18k stars 32 forks source link

replace positron-beta with positron in hyperlinks #3708

Closed cpfiffer closed 1 day ago

cpfiffer commented 4 days ago

Minor quality of life changes. Some of the links in Positron are redirecting to

https://github.com/posit-dev/positron-beta/discussions

instead of the

https://github.com/posit-dev/positron/discussions

discussion page. I corrected these, as well as license pages.

I added some minor formatting of the welcome page code as well.

Note: This GitHub action refers to the beta repo name as well, but I haven't changed it.

jennybc commented 4 days ago

Congrats @cpfiffer for what I think may be the first external pull request 🎉

Some of the changes you make (for example changing single quotes to double) violate hard style conventions for us and touch whitespace in files related to indentation testing. Would you be willing to narrow this down to the specific thing you set out to fix, which is the broken hyperlinks? That will make it easier to merge.

github-actions[bot] commented 4 days ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

cpfiffer commented 4 days ago

I have read the CLA Document and I hereby sign the CLA

cpfiffer commented 4 days ago

Give me a sec to revert the whitespace changes

cpfiffer commented 4 days ago

I rode the whitespace strugglebus (thanks editor with autoformatting) and it has been fixed. This should be okay now.

cpfiffer commented 4 days ago

I'd also squash commit because I have goofy commit titles here

petetronic commented 3 days ago

Thank you! This looks good. As the first fork attempting a PR build on this repo, I see that such a run cannot access secrets. We may no longer need this token given the posit-dev/ark repo now public. I'll look into this.

wesm commented 1 day ago

I rebased this just to get a clean build