Remove PAT from PR CI now that ark repo is public

posit-dev / positron

Positron, a next-generation data science IDE

Other

2.48k stars 77 forks source link

Remove PAT from PR CI now that ark repo is public #3742

Closed petetronic closed 3 months ago

petetronic commented 3 months ago

When building the positron-r extension, we can download releases of ARK without an auth token now that the repo is public.

By not needing a token, our CI workflows for PRs should be possible to run on those made from forks too.

Addresses #3739

QA Notes

If the CI workflow for this PR passes, we should be good to go.

petetronic commented 3 months ago

This should unblock https://github.com/posit-dev/positron/pull/3708 too

petetronic commented 3 months ago

Seems good to me, also update the wiki? https://github.com/posit-dev/positron-wiki/blob/3a985629852ec75d2ef338b321dd8f108b89b65d/machine-setup.qmd#L250

Sure thing, https://github.com/posit-dev/positron-wiki/pull/54

petetronic commented 3 months ago

I'll separately work with Jonathan to review other PAT usages during the full build (there may be cases here the build itself needs one) and python extension tests.